Skip to content

fix: upgrade aws provider to 5.29.0 to support storage_type #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix: upgrade aws provider to 5.29.0 to support storage_type #103

merged 2 commits into from
Jul 25, 2024

Conversation

gmeligio
Copy link
Contributor

what

  • Upgrade terraform-aws-provider to 5.29.0
  • Add variable for storage_type in the test.

why

  • storage_type was released in 5.29.0 but the current minimum version is 5.21.0. This change corrects the minimum required version to 5.29.0

references

closes #86

@gmeligio gmeligio requested review from a team as code owners July 24, 2024 22:16
@gmeligio gmeligio requested review from kevcube and joe-niland July 24, 2024 22:16
@mergify mergify bot added the triage Needs triage label Jul 24, 2024
@gmeligio gmeligio changed the title build: upgrade aws provider to 5.29.0 fix: upgrade aws provider to 5.29.0 to support storage_type Jul 24, 2024
@gberenice
Copy link
Contributor

/terratest

gberenice
gberenice reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small suggestion.

@gmeligio @gberenice
Update examples/complete/variables.tf
8cae5f4 
Co-authored-by: Veronika Gnilitska <30597968+gberenice@users.noreply.github.com>
@gmeligio gmeligio requested a review from gberenice July 25, 2024 15:48
@gberenice
Copy link
Contributor

/terratest

gberenice
gberenice approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gberenice gberenice merged commit 6fc2bac into cloudposse:main Jul 25, 2024
15 checks passed
@mergify mergify bot removed the triage Needs triage label Jul 25, 2024
@github-actions GitHub Actions
Copy link

These changes were released in v0.26.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

@jgalais jgalais jgalais approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argument "storage_type" for aws_docdb_cluster is not expected with AWS provider < 5.29.0, Module Version 0.25.0
3 participants
@gmeligio @gberenice @jgalais