Skip to content

add additional waf features #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 1, 2024
Merged

add additional waf features #791

merged 4 commits into from
Oct 1, 2024

Conversation

@mcalhoun
Copy link
Contributor

@mcalhoun mcalhoun commented Aug 3, 2023

what

  • Add the ability to specify a list of ALBs to attach WAF to
  • Add the ability to specify a list of tags to target ALBs to attach WAF to

why

  • To provider greater flexibility in attaching WAF to ALBs

@mcalhoun mcalhoun requested review from a team as code owners August 3, 2023 18:30
milldr
milldr reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty file, otherwise LGTM

@goruha goruha requested review from goruha and milldr October 1, 2024 12:21
@goruha goruha merged commit e9f6568 into main Oct 1, 2024
4 checks passed
@goruha goruha deleted the feat/add-alb-name-and-tag-support branch October 1, 2024 14:36
goruha added a commit to cloudposse-terraform-components/aws-waf that referenced this pull request Nov 27, 2024
@milldr @goruha
add additional waf features (cloudposse/terraform-aws-components#791)
508108a 
Co-authored-by: Dan Miller <daniel@cloudposse.com>
Co-authored-by: Igor Rodionov <goruha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milldr milldr milldr approved these changes

@goruha goruha Awaiting requested review from goruha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcalhoun @goruha @milldr