feat(kms): updates with embedded policy creation - part2 #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

goruha merged 13 commits into cloudposse:main from Gowiem:masterpoint/kms-key-upgrades

Nov 6, 2024

Member

Gowiem commented Oct 3, 2024

what

Updates the KMS module to support embedded policy creation

why

This allows for easy wiring in of aws-team-role roles into the KMS policy, so we do something like "Admins in the dev account have access to use this Key"

references

This is a continuation of PR feat: updates kms comp with embedded policy creation #523 which I could not continue as I no longer have access to push to Cloud Posse except as a fork 😢
- @nitrocode did a great review with some solid suggestions in feat: updates kms comp with embedded policy creation #523. I have completed my work from that review as part of this newer PR.

Gowiem added 5 commits

November 10, 2022 12:11


          feat: updates kms comp with embedded policy creation


          chore: adds back policy var for backwards compatibility

d5bf21f


          chore: updates kms/README.md with terradocs placeholders

b77fbe0


          Merge branch 'main' of github.com:cloudposse/terraform-aws-components…

b2003cb

… into masterpoint/kms-key-upgrades


          chore(kms): updates from @nitrocode PR feedback 💯

6ee8918

Gowiem requested review from a team as code owners

October 3, 2024 02:02

Gowiem mentioned this pull request

feat: updates kms comp with embedded policy creation #523

Closed

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/main.tf Show resolved Hide resolved

nitrocode reviewed

View reviewed changes

modules/kms/README.md Show resolved Hide resolved

Member

nitrocode commented Oct 3, 2024

Thanks for addressing all the changes @Gowiem. Feel free to ignore my comments as I do not have review power here. I got the @ sign notification so thought I'd re-review.

goruha added 6 commits

October 3, 2024 11:43


          Update variables.tf

d9e546b


          Update variables.tf

209b430


          Update variables.tf

7c72482


          Update variables.tf

3325ee9


          Merge branch 'main' into masterpoint/kms-key-upgrades

513924b


          Merge branch 'main' into masterpoint/kms-key-upgrades

437cdb7

goruha approved these changes

View reviewed changes

goruha added 2 commits

October 10, 2024 11:25


          Merge branch 'main' into masterpoint/kms-key-upgrades

ce12217


          Merge branch 'main' into masterpoint/kms-key-upgrades

1ad1a5c

goruha approved these changes

View reviewed changes

Benbentwo approved these changes

View reviewed changes

Member

Benbentwo left a comment

In general looks good, think we can make the policies tighter or customizable as a future enhancement.

Member

goruha commented Nov 6, 2024

@Benbentwo, we need to address all PRs before codefreeze. So, I liberate the criteria

goruha merged commit 8b6a602 into cloudposse:main

4 checks passed

goruha added a commit to cloudposse-terraform-components/aws-kms that referenced this pull request


          feat(kms): updates with embedded policy creation - part2 (cloudposse/…

e16153d

…terraform-aws-components#1136)

Co-authored-by: Igor Rodionov <goruha@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet