Skip to content

chore(deps): update terraform cloudposse/ec2-autoscale-group/aws to v0.41.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 4, 2024

This PR contains the following updates:

Package Type Update Change
cloudposse/ec2-autoscale-group/aws (source) module minor 0.35.1 -> 0.41.0

Release Notes

cloudposse/terraform-aws-ec2-autoscale-group (cloudposse/ec2-autoscale-group/aws)

v0.41.0

Compare Source

add max_healthy_percentage - option used during instance refresh @​scott-doyland-burrows (#​149)

what

This is adding the max_healthy_percentage option.

This allows the instance refresh to set this value.

min_healthy_percentage is already set as an option.

why

The option is currently missing from the terraform module.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#max_healthy_percentage

fix: Terratest Account ID @​milldr (#​150)

what

  • Remove old account ID check from tests

why

  • Account ID has changed. We shouldnt use the account ID to check

references

🤖 Automatic Updates

Migrate new test account @​osterman (#​148)

what

  • Update .github/settings.yml
  • Update .github/chatops.yml files

why

  • Re-apply .github/settings.yml from org level to get terratest environment
  • Migrate to new test account

References

  • DEV-388 Automate clean up of test account in new organization
  • DEV-387 Update terratest to work on a shared workflow instead of a dispatch action
  • DEV-386 Update terratest to use new testing account with GitHub OIDC
Update .github/settings.yml @​osterman (#​147)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update .github/settings.yml @​osterman (#​146)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update .github/settings.yml @​osterman (#​145)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub

v0.40.0

Compare Source

fix: Tagging @​MaxymVlasov (#​143)

why

var.tags does not provide any tags if you rely on context:

module {
  ...
  context = module.this.context
}

🤖 Automatic Updates

Update .github/settings.yml @​osterman (#​142)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update .github/settings.yml @​osterman (#​141)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update release workflow to allow pull-requests: write @​osterman (#​140)

what

  • Update workflow (.github/workflows/release.yaml) to have permission to comment on PR

why

  • So we can support commenting on PRs with a link to the release
Update GitHub Workflows to use shared workflows from '.github' repo @​osterman (#​139)

what

  • Update workflows (.github/workflows) to use shared workflows from .github repo

why

  • Reduce nested levels of reusable workflows
chore(deps): update terraform cloudposse/dynamic-subnets/aws to v2.4.2 @​renovate (#​131) This PR contains the following updates:
Package Type Update Change
cloudposse/dynamic-subnets/aws (source) module patch 2.4.1 -> 2.4.2

Release Notes
cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)
v2.4.2

Compare Source

🚀 Enhancements
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​&#​8203;renovate (#&#​8203;191)

This PR contains the following updates:

Package Type Update Change
cloudposse/utils/aws (source) module minor 1.3.0 -> 1.4.0

Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0

Compare Source

Add il-central-1 region @​&#​8203;&#&#​8203;8203;jasonmk (#&#&#​8203;8203;31)
what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references
Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;27)

Rebuild github dir from the template


🤖 Automatic Updates
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​&#​8203;renovate (#&#​8203;191)

This PR contains the following updates:

Package Type Update Change
cloudposse/utils/aws (source) module minor 1.3.0 -> 1.4.0

Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0

Compare Source

Add il-central-1 region @​&#​8203;&#&#​8203;8203;jasonmk (#&#&#​8203;8203;31)
what

Add new Tel Aviv (il-central-1) region

why

Provide full coverage

references
Sync github @​&#​8203;&#&#​8203;8203;max-lobur (#&#&#​8203;8203;27)

Rebuild github dir from the template


Update README.md and docs @​&#​8203;cloudpossebot (#&#​8203;189)
what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


Update GitHub Workflows to Fix ReviewDog TFLint Action @​osterman (#​138)

what

  • Update workflows (.github/workflows) to add issue: write permission needed by ReviewDog tflint action

why

  • The ReviewDog action will comment with line-level suggestions based on linting failures
Update GitHub workflows @​osterman (#​137)

what

  • Update workflows (.github/workflows/settings.yaml)

why

  • Support new readme generation workflow.
  • Generate banners
Use GitHub Action Workflows from `cloudposse/.github` Repo @​osterman (#​136)

what

  • Install latest GitHub Action Workflows

why

  • Use shared workflows from cldouposse/.github repository
  • Simplify management of workflows from centralized hub of configuration
Add GitHub Settings @​osterman (#​135)

what

  • Install a repository config (.github/settings.yaml)

why

  • Programmatically manage GitHub repo settings
Update README.md and docs @​cloudpossebot (#​132)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

Update Scaffolding @​osterman (#​133)

what

  • Reran make readme to rebuild README.md from README.yaml
  • Migrate to square badges
  • Add scaffolding for repo settings and Mergify

why

  • Upstream template changed in the .github repo
  • Work better with repository rulesets
  • Modernize look & feel
chore(deps): update terraform cloudposse/vpc/aws to v2.2.0 @​renovate (#​130) This PR contains the following updates:
Package Type Update Change
cloudposse/vpc/aws (source) module minor 2.1.1 -> 2.2.0

Release Notes
cloudposse/terraform-aws-vpc (cloudposse/vpc/aws)
v2.2.0

Compare Source


Update README.md and docs @​cloudpossebot (#​129)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

chore(deps): update terraform cloudposse/vpc/aws to v2.1.1 @​renovate (#​128) This PR contains the following updates:
Package Type Update Change
cloudposse/vpc/aws (source) module patch 2.1.0 -> 2.1.1

Release Notes
cloudposse/terraform-aws-vpc (cloudposse/vpc/aws)
v2.1.1

Compare Source

Add support for network address usage metrics @​&#​8203;lanzrein (#&#​8203;124)
what

This PR adds support for Network Address Usage Metrics on the VPC.
AWS documentation : https://docs.aws.amazon.com/vpc/latest/userguide/network-address-usage.html
Terraform documentation : https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc#enable_network_address_usage_metrics

why

Network Address Usage metrics can help monitor the growth of a VPC and would be useful for any user.
Enable this after creating a VPC does not trigger recreation of the VPC.

references

closes #​115

Sync github @​&#​8203;max-lobur (#&#​8203;120)

Rebuild github dir from the template

🤖 Automatic Updates
Update README.md and docs @​&#​8203;cloudpossebot (#&#​8203;125)
what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


v0.39.0

Compare Source

Change mixed instances policy fields to optional @​pagmerek (#​126)

what

  • change variable field of mixed_instances_policy to optional

why

In my other PR for terraform ECS component I changed the default value of variable that is being passed here. Without this change terraform will complain that there is no such field as instances_distribution/override

references

NOTE: This PR must be merged first and then I will change version of ASG component in ECS component

v0.38.0

Compare Source

🚀 Enhancements

Add optional network_interface_id variable @​gbarna-bd (#​124)

what

  • Add optional network_interface_id variable to launch_template

why

  • Allow the attaching of existing network interfaces

references

v0.37.2

Compare Source

🚀 Enhancements

Require AWS provider 5.16+ @​raymondchen625 (#​123)

what

Version v0.36.0 does not work with AWS Provider 4.X.

why

In PR #​121 of v0.36.0, the preference key scale_in_protected_instances, which had been available only since AWS Provider 5.16.0 introduced by PR#33310, was added. That basically upgrades the required AWS provider version to 5.16.0+.
We will get errors like the below while planning with AWS provider <5.16.0:

│ Error: Unsupported argument
│
│   on .terraform/modules/autoscale_group/main.tf line 187, in resource "aws_autoscaling_group" "default":
│  187:           scale_in_protected_instances = lookup(preferences.value, "scale_in_protected_instances", null)
│
│ An argument named "scale_in_protected_instances" is not expected here.

references

🐛 Bug Fixes

Require AWS provider 5.16+ @​raymondchen625 (#​123)

what

Version v0.36.0 does not work with AWS Provider 4.X.

why

In PR #​121 of v0.36.0, the preference key scale_in_protected_instances, which had been available only since AWS Provider 5.16.0 introduced by PR#33310, was added. That basically upgrades the required AWS provider version to 5.16.0+.
We will get errors like the below while planning with AWS provider <5.16.0:

│ Error: Unsupported argument
│
│   on .terraform/modules/autoscale_group/main.tf line 187, in resource "aws_autoscaling_group" "default":
│  187:           scale_in_protected_instances = lookup(preferences.value, "scale_in_protected_instances", null)
│
│ An argument named "scale_in_protected_instances" is not expected here.

references

v0.37.1

Compare Source

fix: block_device_mappings required optional fields @​MaxymVlasov (#​127)

what

Fix 0.37.0

│ Error: Invalid value for input variable
│ 
│   on main.tf line 125, in module "autoscale_group":
│  125:   block_device_mappings       = var.block_device_mappings
│ 
│ The given value is not suitable for
│ module.autoscale_group.var.block_device_mappings declared at
│ .terraform/modules/autoscale_group/variables.tf:72,1-33: incorrect list
│ element type: attribute "ebs": attribute "throughput" is required.
╵

why

As per the code in main.tf, all these stuff are optional

https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/blob/b757eb9037b9eae3235522800530117e66d535b2/main.tf#L6-L24

references

https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/97

🤖 Automatic Updates

Update Terraform cloudposse/dynamic-subnets/aws to v2.4.1 @​renovate (#​125)

This PR contains the following updates:

Package Type Update Change
cloudposse/dynamic-subnets/aws (source) module minor 2.3.0 -> 2.4.1

Release Notes
cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)
v2.4.1

Compare Source

🚀 Enhancements
Add subnet ARNs to outputs @​&#​8203;Nuru (#&#​8203;188)
what
  • Add subnet ARNs to outputs
why
v2.4.0

Compare Source

Update dependencies, remove deprecation, add NACL example @​&#​8203;Nuru (#&#​8203;184)
Note
Dropping support for deprecated EC2-Classic

With this release, EIPs allocated for NAT ingress are allocated in the default domain. This most likely does not affect you, but for accounts created before 2013-12-04 (almost 10 years ago as of this writing), the default domain could be EC2-Classic rather than the current VPC. Previously this module forced the EIPs to be in the VPC domain, but the breaking changes between AWS Provider v4 and v5 make that difficult.

If you find yourself in the rare situation where the EIPs allocated by this module are in EC2-Classic but you want them in VPC, then create the EIPs outside of this module and supply them to this module via nat_elastic_ips.

Custom NACLs

This release includes an example (examples/nacls/) showing how to create custom NACLs in conjunction with this module. Note that by default, this module creates wide-open NACLs, and subnets can only have one NACL associated with them. If you try to add a NACL to a subnet without disabling the default NACLs, you may get a possibly confusing error like:

│ Error: creating EC2 Network ACL: creating EC2 Network ACL (acl-0376c5f12dd9d784d) Association: InvalidAssociationID.NotFound: The association ID 'aclassoc-0818d5a9e3876a2bb' does not exist

See https://github.com/hashicorp/terraform-provider-aws/issues/31888

what
  • Make appropriate inputs non-nullable (treat an input of null as meaning "default")
  • Remove aws_eip vpc = true
  • Update terraform cloudposse/utils/aws to v1.3.0 (Supersedes and closes #​182)
  • Add example of how to add custom NACLs to subnets created by this module (Supersedes and closes #​176)
  • Update tests and test framework
why
  • Allow better, more consistent configuration
  • Deprecated
  • Include support for new AWS regions
  • Encourage composition of modules and resources rather than aggregation of functionality into bloated modules (c.f. #​176)
  • Stay current with features, bug fixes, and security updates
references

v0.37.0

Compare Source

* add throughput to block_device_mapping @​zaksamalik (#​97)

what

  • add throughput to block_device_mapping

why

  • allows throughput configuration for block device mappings

references

  • closes #​96

v0.36.0

Compare Source

🚀 Enhancements

Fix: instance refresh missing properties @​ebarriosjr (#​121)

what

This PR adds two missing properties to the instance_refresh stanza.

why

Right now there is no way to configure scale_in_protected_instances and standby_instances in the instance refresh stanza.

references

This solves: #​120

🤖 Automatic Updates

Update README.md and docs @​cloudpossebot (#​122)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner December 4, 2024 05:52
@mergify mergify bot added the auto-update This PR was automatically generated label Dec 4, 2024
Copy link

mergify bot commented Dec 4, 2024

/terratest

@mergify mergify bot added the needs-test Needs testing label Dec 4, 2024
Copy link

mergify bot commented Jan 3, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added the stale This PR has gone stale label Jan 3, 2025
Copy link

mergify bot commented Jan 3, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟠 Require terratest

Waiting checks: test/terratest.

This rule require terratest status

  • check-success = test/terratest

Copy link

coderabbitai bot commented Jan 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot removed the stale This PR has gone stale label Jan 3, 2025
Copy link

mergify bot commented Jan 10, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 10, 2025
Copy link

mergify bot commented Jan 17, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 17, 2025
Copy link

mergify bot commented Jan 24, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Jan 24, 2025
@renovate renovate bot force-pushed the renovate/cloudposse-ec2-autoscale-group-aws-0.x branch from 50dd089 to c001084 Compare January 27, 2025 12:18
@renovate renovate bot requested review from a team as code owners January 27, 2025 12:18
@renovate renovate bot changed the title chore(deps): update terraform cloudposse/ec2-autoscale-group/aws to v0.40.0 chore(deps): update terraform cloudposse/ec2-autoscale-group/aws to v0.41.0 Jan 27, 2025
Copy link

mergify bot commented Feb 26, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Feb 26, 2025
Copy link

mergify bot commented Mar 5, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Mar 5, 2025
Copy link

mergify bot commented Apr 26, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Apr 26, 2025
Copy link

mergify bot commented Apr 26, 2025

/terratest

Copy link

There are no real tests for this component. So we set terratest statuses to successful execution without running any tests

Copy link

mergify bot commented May 3, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels May 3, 2025
Copy link

mergify bot commented May 3, 2025

/terratest

Copy link

mergify bot commented May 10, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels May 10, 2025
Copy link

mergify bot commented May 10, 2025

/terratest

Copy link

mergify bot commented May 17, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels May 17, 2025
Copy link

mergify bot commented May 17, 2025

/terratest

Copy link

mergify bot commented May 24, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels May 24, 2025
Copy link

mergify bot commented May 24, 2025

/terratest

@cloudposse-releaser cloudposse-releaser bot enabled auto-merge May 30, 2025 14:28
Copy link
Contributor Author

renovate bot commented Jun 3, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@cloudposse-releaser cloudposse-releaser bot added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 25b84d1 Jun 3, 2025
15 checks passed
@cloudposse-releaser cloudposse-releaser bot deleted the renovate/cloudposse-ec2-autoscale-group-aws-0.x branch June 3, 2025 16:25
Copy link

github-actions bot commented Jun 3, 2025

These changes were released in v1.535.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated needs-test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant