Bugfix: deprecated params & unused datasource from lookup

[Benbentwo]

what

• Bugfix:
  • deprecated parameters in module
  • Unused datasource

why

• Bugfixes for version 2

references

• remove datadog lookup #39

Summary by CodeRabbit

• Chores
  • Removed retrieval of the Datadog application key from AWS SSM Parameter Store.
  • Removed unused scaling adjustment parameters from the autoscaling configuration.

[coderabbitai]

Walkthrough

This change removes the retrieval of the Datadog application key from AWS SSM Parameter Store in the Datadog agent Terraform configuration. Additionally, it eliminates the scale_up_adjustment and scale_down_adjustment parameters from the ECS CloudWatch autoscaling module in the main Terraform configuration.

Changes

File(s)	Change Summary
src/datadog-agent.tf	Removed the data source block for fetching the Datadog app key from AWS SSM Parameter Store.
src/main.tf	Removed scale_up_adjustment and scale_down_adjustment parameters from the ECS autoscaling module.

Sequence Diagram(s)

sequenceDiagram
    participant Terraform
    participant AWS SSM
    participant Datadog Agent

    %% Old flow
    Note over Terraform, AWS SSM: (Old) Fetch Datadog app key from SSM if enabled
    Terraform->>AWS SSM: Get datadog_app_key
    AWS SSM-->>Terraform: Return app key
    Terraform->>Datadog Agent: Configure with app key

    %% New flow
    Note over Terraform, Datadog Agent: (New) SSM fetch for app key removed
    Terraform->>Datadog Agent: Configure (without SSM app key)

Loading

Possibly related PRs

• remove datadog lookup #39: Added the conditional Datadog SSM parameter data source, which is now being removed in this PR.

Suggested labels

major, needs-test

Poem

A hop and a skip through the Terraform glade,
Out goes the app key, no SSM parade!
Autoscaling’s lighter, no more adjust fuss,
The code’s less cluttered—less for us to discuss.
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/main.tf (1)

454-455: Consider exposing cooldown settings to variables

Hardcoding scale_up_cooldown and scale_down_cooldown reduces flexibility. It’s better to surface these values as module inputs (with sensible defaults) so downstream consumers can adjust them without forking.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0e675e and d9031fb.

📒 Files selected for processing (2)

• src/datadog-agent.tf (0 hunks)
• src/main.tf (1 hunks)

💤 Files with no reviewable changes (1)

• src/datadog-agent.tf

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: component / terraform / Lint (./src)
• GitHub Check: component / terraform / bats
• GitHub Check: Summary

🔇 Additional comments (2)

src/main.tf (2)

444-453: Approve autoscaling basic configuration

The service_name, cluster_name, min_capacity, and max_capacity inputs align with the module’s API and look correct. Ensure that var.task reliably provides min_capacity/max_capacity in all deployment scenarios.

---

444-456: Verify removal of scale adjustment parameters

The PR removes the deprecated scale_up_adjustment and scale_down_adjustment parameters. Please confirm that cloudposse/ecs-cloudwatch-autoscaling/aws version 1.0.0 no longer requires those inputs and that your autoscaling policies behave as expected.

For cloudposse/ecs-cloudwatch-autoscaling/aws version 1.0.0, have the `scale_up_adjustment` and `scale_down_adjustment` variables been removed or deprecated?

[github-actions]

These changes were released in v2.0.2.