Skip to content

feat: add performance insights variable #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RoseSecurity
Copy link

@RoseSecurity RoseSecurity commented Apr 14, 2025

what and why

Note

The module already supports this functionality (we just need to pass the variable)

  • Provide the ability to enable performance insights for the DocumentDB cluster

references

Summary by CodeRabbit

  • New Features
    • Introduced a new option to enable Performance Insights for enhanced monitoring of your database cluster.
    • Updated the database cluster module to a newer version for improved functionality.

@RoseSecurity RoseSecurity requested review from a team as code owners April 14, 2025 17:44
Copy link

coderabbitai bot commented Apr 14, 2025

"""

Walkthrough

The pull request updates the DocumentDB cluster module by changing its version from 0.14.0 to 0.27.0 and adding a new parameter, enable_performance_insights, which is linked to a newly declared boolean variable. This variable, defined in the variables file with a default value of false, specifies whether to enable Performance Insights for the DB Instance. No existing parameters or functionalities are altered.

Changes

File(s) Change Summary
src/main.tf, src/variables.tf Updated documentdb_cluster module version to 0.27.0 and added a new parameter enable_performance_insights; declared a new boolean variable enable_performance_insights (default false) for Performance Insights.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant TF as Terraform Config
    participant Mod as documentdb_cluster Module
    participant AWS as AWS DocumentDB
    Dev->>TF: Set enable_performance_insights variable (bool)
    TF->>Mod: Pass enable_performance_insights parameter
    Mod->>AWS: Configure Performance Insights based on parameter
Loading

Poem

Oh, I hop in code with a joyful spree,
Enabling insights so our DB can see.
A boolean flag to light the way,
In DocumentDB, brighten the day!
Hoppity cheers from this CodeRabbit, hooray! 🐇✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bef7f9 and abdd964.

📒 Files selected for processing (2)
  • src/main.tf (2 hunks)
  • src/variables.tf (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/variables.tf
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main.tf
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RoseSecurity RoseSecurity changed the title feat: add performance insights input feat: add performance insights variable Apr 14, 2025
@mergify mergify bot added the needs-test Needs testing label Apr 14, 2025
@RoseSecurity
Copy link
Author

I'm not sure why these tests are failing as we are currently using this code in our downstream component and it works as intended

@RoseSecurity RoseSecurity requested a review from goruha April 22, 2025 15:49
Copy link

mergify bot commented May 14, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels May 14, 2025
@RoseSecurity RoseSecurity added enhancement New feature or request minor New features that do not break anything and removed needs-test Needs testing labels May 23, 2025
Copy link

mergify bot commented May 30, 2025

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

@mergify mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels May 30, 2025
@RoseSecurity
Copy link
Author

/terratest

@cloudpossebot cloudpossebot force-pushed the add-performance-insights-input branch from 6bef7f9 to abdd964 Compare June 3, 2025 07:30
@mergify mergify bot added the needs-test Needs testing label Jun 3, 2025
@goruha goruha added this pull request to the merge queue Jun 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2025
@RoseSecurity
Copy link
Author

I believe this is good to go?

@goruha goruha added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor New features that do not break anything needs-test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants