-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add performance insights variable #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
""" WalkthroughThe pull request updates the DocumentDB cluster module by changing its version from Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant TF as Terraform Config
participant Mod as documentdb_cluster Module
participant AWS as AWS DocumentDB
Dev->>TF: Set enable_performance_insights variable (bool)
TF->>Mod: Pass enable_performance_insights parameter
Mod->>AWS: Configure Performance Insights based on parameter
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I'm not sure why these tests are failing as we are currently using this code in our downstream component and it works as intended |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
/terratest |
6bef7f9
to
abdd964
Compare
I believe this is good to go? |
what and why
Note
The module already supports this functionality (we just need to pass the variable)
references
Summary by CodeRabbit