modify cluster-type usage #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to your contribution, the maintainers will review it as soon as they can! |
|
The release note is either empty or incomplete, please consider: |
gitautomator
bot
added
the
documentation
jwcesign
reviewed
May 28, 2025
| @@ -53,7 +53,7 @@ func (o *Options) AddFlags(fs *coreoptions.FlagSet) { | |||
| fs.BoolVar(&o.Interruption, "interruption", env.WithDefaultBool("INTERRUPTION", true), "Enable interruption handling.") | |||
| fs.BoolVar(&o.TelemetryShare, "telemetry-share", env.WithDefaultBool("TELEMETRY_SHARE", true), "Enable telemetry sharing.") | |||
| fs.IntVar(&o.APGCreationQPS, "apg-qps", int(env.WithDefaultInt64("APG_CREATION_QPS", 100)), "The QPS limit for creating AutoProvisionGroup.") | |||
| fs.StringVar(&o.ClusterType, "cluster-type", env.WithDefaultString("CLUSTER_TYPE", "ACKManaged"), "Type of cluster, which specifies the method to generate userdata. The default is ACKManaged, with an option for Custom configuration.") | |||
| fs.StringVar(&o.ClusterType, "cluster-type", env.WithDefaultString("CLUSTER_TYPE", "ACKManaged"), "Type of cluster, which specifies the method to generate userdata. The default is ACKManaged, with an option for Custom configuration. If your cluster-type is not default or ACKManaged, you need to add taint(karpenter.sh/unregistered:NoExecute) before the node is ready") | |||
There was a problem hiding this comment.
can we add a controller to do it?
There was a problem hiding this comment.
Thanks @kaiiyvwu , can you help create a issue to track the feature?
|
/lgtm |
|
Will implement the controller next, let's merge this first. /approve |
![gitautomator[bot]](https://avatars.githubusercontent.com/in/841517?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
If the cluster type is ACKManaged and a new node is not tainted with karpenter.sh/unregistered:NoExecute, then the node will not be managed by Karpenter afterward.
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
Does this PR introduce a user-facing change?