feat(VIDEO-20073): video-specific config #920
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kalifyaniv-cloudinary
approved these changes
Oct 28, 2025
| export const videoPlayer = (id, playerOptions = {}, ready) => { | ||
| const { videoElement, options } = getConfig(id, playerOptions); | ||
| if (options.profile) { | ||
| console.warn('Profile option requires async initialization. Use cloudinary.player() instead of cloudinary.videoPlayer()'); |
Comment on lines
+44
to
52
| const cloudinaryVideoPlayerLegacyConfig = () => { | ||
| console.warn( | ||
| 'Cloudinary.new() is deprecated and will be removed. Please use cloudinary.videoPlayer() instead.' | ||
| ); | ||
| return { | ||
| videoPlayer: getVideoPlayer(config), | ||
| videoPlayers: getVideoPlayers(config) | ||
| videoPlayer, | ||
| videoPlayers | ||
| }; | ||
| }; |
There was a problem hiding this comment.
isnt it time to deprecate it for real?
There was a problem hiding this comment.
In theory, yes, absolutely.
On the other hand, this.
* chore: simplify and test build system * docs: transformations example page * chore: refactor and cleanup icons (#923)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Player Initialization API and Profile Configuration
Jira: https://cloudinary.atlassian.net/browse/VIDEO-20073
Overview
Refactors player initialization to centralize profile and video-specific configuration fetching, laying the groundwork for asset-level config support.
Prepared infrastructure for video-specific configuration fetching
This refactoring centralizes all configuration fetching logic in
src/utils/fetch-config.js, making it straightforward to support per-video configurations. The new architecture cleanly handles:The unified
fetchAndMergeConfigutility provides a single point for all config resolution, properly merging profiles with player options and maintaining analytics metadata.Key Changes
Code Organization
src/utils/fetch-config.js- centralized config fetching for profiles and asset-specific settingssrc/player.js- logic moved to appropriate locationscloudinaryConfigextraction intoextractOptions()src/index.jsAPI Clarity
videoPlayer,videoPlayers) - Simple use casesplayer,players) - Profile/config supportprofileoption usedTesting
Benefits
✅ Infrastructure ready for video-specific config expansion
✅ Cleaner code organization and maintainability
✅ Clear sync vs async API contracts
✅ Full backward compatibility
Breaking Changes
None