Skip to content

Update default node version to 22 #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

Update default node version to 22 #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d53641
Update manifest.yml
corporatemax Apr 24, 2025
cda14ed
Update node version in default_test.go
corporatemax Apr 28, 2025
cae2fe7
fix version in matcher for default_test
corporatemax Apr 30, 2025
ed0e6f6
Update version of override_buildpack
corporatemax May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/util/override_buildpack/override.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
nodejs:
dependencies:
- name: node
version: 18.99.99
version: 22.99.99
uri: https://buildpacks.cloudfoundry.org/dependencies/node/node.10.99.99-linux-x64.tgz
file: BUILDPACK_DIR/node.tgz
sha256: 062d906c87839d03b243e2821e10653c89b4c92878bfe2bf995dec231e117bfc
Expand Down
2 changes: 1 addition & 1 deletion manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
language: nodejs
default_versions:
- name: node
version: 18.x
version: 22.x
- name: python
version: 3.11.x
include_files:
Expand Down
4 changes: 2 additions & 2 deletions src/nodejs/integration/default_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func testDefault(platform switchblade.Platform, fixtures string) func(*testing.T
Execute(name, filepath.Join(fixtures, "simple"))
Expect(err).NotTo(HaveOccurred())

Expect(logs).To(ContainLines(MatchRegexp("Installing node 18\\.\\d+\\.\\d+")))
Expect(logs).To(ContainLines(MatchRegexp("Installing node 22\\.\\d+\\.\\d+")))

Eventually(deployment).Should(Serve("Hello world!"))

Expand All @@ -57,7 +57,7 @@ func testDefault(platform switchblade.Platform, fixtures string) func(*testing.T
}
Expect(json.NewDecoder(response.Body).Decode(&process)).To(Succeed())

Expect(process.Version).To(MatchRegexp(`v18\.\d+\.\d+`))
Expect(process.Version).To(MatchRegexp(`v22\.\d+\.\d+`))
Expect(process.Env.NodeOptions).To(BeEmpty())
Expect(process.Env.NodeHome).To(Equal("/home/vcap/deps/0/node"))
Expect(process.Env.NodeEnv).To(Equal("production"))
Expand Down
Loading