Feature/add module spec #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/triage |
PI-Victor
force-pushed
the
feature/add-module-spec
branch
from
8412e17 to
915a5f6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces updates to the Skyforge plugin API and the accompanying implementation in the Hetzner plugin while also enhancing module documentation.
- Updated the wit interface in spec/wit/skyforge.v1.wit by replacing deserialize-config with verify-config and get-version.
- Modified the SDK macros to generate the new trait functions and updated the Hetzner plugin implementation accordingly.
- Enhanced documentation in the Hetzner specs and adjusted the network spec formatting.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/wit/skyforge.v1.wit | Changed API signature by removing deserialize-config and adding verify-config and get-version. |
| crates/sdk/skyforge-sdk-macros/src/lib.rs | Updated macro expansion to implement get_version and verify_config functions. |
| crates/plugins/hetzner/src/resources/instance.rs | Minor documentation adjustment with added comment slashes. |
| crates/plugins/hetzner/src/lib.rs | Updated plugin implementation to align with the new API signatures. |
| crates/plugins/hetzner/spec/network.star | Commented out network module code with updated documentation. |
| crates/plugins/hetzner/spec/base.star | Expanded documentation and module configuration details. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Victor Palade <victor@cloudflavor.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.