Skip to content

feat: add Send+Sync+Display traits to KvError #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add Send+Sync+Display traits to KvError #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions worker/src/kv/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,21 @@ pub enum KvError {
InvalidKvStore(String),
}

unsafe impl Send for KvError {}
unsafe impl Sync for KvError {}

impl std::fmt::Display for KvError {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
KvError::JavaScript(value) => write!(f, "js error: {value:?}"),
KvError::Serialization(e) => write!(f, "unable to serialize/deserialize: {e}"),
KvError::InvalidKvStore(binding) => write!(f, "invalid kv store: {binding}"),
}
}
}

impl std::error::Error for KvError {}

impl From<KvError> for JsValue {
fn from(val: KvError) -> Self {
match val {
Expand Down