adding most of the missing fields in CfProperties #233
Conversation
…riate Rust + bindgen representations; plus some remaining TODOs and a review comment on related code
| #[wasm_bindgen] | ||
| #[derive(Clone, Copy)] | ||
| pub enum ResizeFit { | ||
| ScaleDown, |
There was a problem hiding this comment.
Values of the enum types (ResizeFit, ResizeFormat, ResizeMetadata, ResizeOnerror) will need to be converted with their target naming scheme (kebab scheme) accounted for, essentially like it's done above with PolishConfig.
For example, ScaleDown should be serialised into the string scale-down.
I see the existing &str conversions in the file are spelled out explicitly, which is a bit of a shame, since that means a lot of repetition. I would use strum::IntoStaticStr, but I don't know if the maintainers are okay with pulling in that dependency.
There was a problem hiding this comment.
i like to thank you for your help but i need more experience with you
|
@seeekr if you're keen on continuing with this PR, I have proposed some changes in https://github.com/jakubadamw/workers-rs/commits/add-cf-properties. 🙂 I tested the branch (well, some of the properties, at least) in a personal project. Seems to work fine! Thank you. |
|
sorry never got around to finishing this! |
It's ok appears this isn't being maintained any further as the many finished PR's are just sitting there. I've started my own project using Claude Code to implement all these, so thank you for the submission as it gives a starting point for what I need it to complete for using with RUST. |
|
great to hear it is useful nevertheless! good luck!
…On Tue 20. May 2025 at 22:42, Peter M. Hammond ***@***.***> wrote:
*PeterMHammond* left a comment (cloudflare/workers-rs#233)
<#233 (comment)>
sorry never got around to finishing this!
It's ok appears this isn't being maintained any further as the many
finished PR's are just sitting there. I've started my own project using
Claude Code to implement all these, so thank you for the submission as it
gives a starting point for what I need it to complete for using with RUST.
—
Reply to this email directly, view it on GitHub
<#233 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACJ6JW6E5A6A56YTCJZESD27OHU3AVCNFSM6AAAAAB5RNIO4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJVG44DGNRVGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
There's still a few holes, but it's good enough for my own purposes. Would be nice if someone could review this and leave me some feedback :)
Also there's a review comment in there that I'd like to discuss!