Skip to content

Fix a confusing type parameter for generating signatures. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2025
Merged

Fix a confusing type parameter for generating signatures. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ec6581
Fix a confusing type parameter for generating signatures.
AkshatM Jun 14, 2025
137cecb
Merge branch 'cloudflare:main' into main
AkshatM Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ members = [
resolver = "2"

[workspace.package]
version = "0.1.0"
version = "0.1.1"
authors = [
"Akshat Mahajan <akshat@cloudflare.com>",
"Gauri Baraskar <gbaraskar@cloudflare.com>",
Expand All @@ -32,4 +32,4 @@ serde_json = "1.0.140"
data-url = "0.3.1"

# workspace dependencies
web-bot-auth = { version = "0.1.0", path = "./crates/web-bot-auth" }
web-bot-auth = { version = "0.1.1", path = "./crates/web-bot-auth" }
4 changes: 2 additions & 2 deletions crates/web-bot-auth/src/message_signatures.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::components::CoveredComponent;
use crate::keyring::{KeyRing, PublicKey};
use crate::keyring::KeyRing;
use indexmap::IndexMap;
use sfv::SerializeValue;
use std::fmt;
Expand Down Expand Up @@ -292,7 +292,7 @@ impl MessageSigner {
&self,
message: &mut impl UnsignedMessage,
expires: Duration,
signing_key: &PublicKey,
signing_key: &Vec<u8>,
) -> Result<(), ImplementationError> {
let components_to_cover = message.fetch_components_to_cover();
let mut sfv_parameters = sfv::Parameters::new();
Expand Down