Skip to content

Add protocol to signature-agent #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

thibmeu
Copy link
Collaborator

@thibmeu thibmeu commented Jun 13, 2025

Signature-Agent MUST be prefixed by a protocol as it's a URI. In our case, both for test and examples, we use https.

This commit also regenerates the test vectors, so that the draft can be updated

Signature-Agent MUST be prefixed by a protocol as it's a URI.
In our case, both for test and examples, we use `https`.
@thibmeu thibmeu requested review from AkshatM and armfazh June 13, 2025 14:20
@thibmeu thibmeu self-assigned this Jun 13, 2025
@thibmeu thibmeu added the bug Something isn't working label Jun 13, 2025
@gcloudflare
Copy link
Contributor

Approved

@thibmeu thibmeu merged commit f6731ee into cloudflare:main Jun 13, 2025
2 checks passed
@thibmeu thibmeu deleted the fix-signature-agent-protocol branch June 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants