Skip to content

Automates the creation of the extension #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2025

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Jun 6, 2025

Automates bundling the chrome extension.
The bundle:chrome is now a script that:

  • generates a signing key
  • updates manifest
  • packs the extension using crx
  • creates policy files for installation.

@armfazh armfazh force-pushed the armfazh/extID branch 2 times, most recently from 1a34abf to 7b57ce6 Compare June 10, 2025 19:51
Copy link
Collaborator

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall ok. thanks for updating it

@armfazh armfazh requested a review from thibmeu June 12, 2025 00:22
Copy link
Collaborator

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good. before approving, I'd like to resolve the issue with awaiting _sodium.ready. It seems like unecessary code

@thibmeu thibmeu merged commit 1f4d17e into cloudflare:main Jun 12, 2025
2 checks passed
@armfazh armfazh deleted the armfazh/extID branch June 12, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants