Make all public structs cloneable, except for ImplementationError #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor quality-of-life improvement to make it easy to embed these structs in wrappers that implement `Clone()`. It came up during tests, for example, that would be greatly simplified if a covered component could be `Cloned`. `ImplementationError` cannot be `Clone()`d because `sfv::Error` is not cloneable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor quality-of-life improvement to make it easy to embed these structs in wrappers that implement
Clone(). It came up during tests, for example, that would be greatly simplified if a covered component could beCloned.ImplementationErrorcannot beClone()d becausesfv::Erroris not cloneable.