Introduce timing information on verification + add component tests #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibmeu
reviewed
May 28, 2025
| @@ -589,7 +599,9 @@ impl MessageVerifier { | |||
| .and_then(|key| keyring.get(key)), | |||
| }) | |||
| .ok_or(ImplementationError::NoSuchKey)?; | |||
| let generation = Instant::now(); | |||
There was a problem hiding this comment.
i recall instant::now() not working well with wasm32. Did you test? Might be a test target we add so Cloudflare workers are supported
There was a problem hiding this comment.
I added a build target for wasm32 in GitHub Actions, I would need to install a test runner for WASM to actually run the tests themselves. I think this should be sufficient?
AkshatM
force-pushed
the
main
branch
4 times, most recently
from
69b8bb2 to
6033f52
Compare
AkshatM
changed the title
Users attempting to profile the time it takes to verify currently need to measure both time to generating a signature base, as well as time to actually perform message verification using the underlying algorithm. This change augments the return signature of `verify()` to return benchmarks of both operations, so that drill-down views into overhead are possible. I've also revisited some of the `component` library changes to add a more expansive suite of tests. The tests revealed a few typos scattered here and there that led to invalid semantics, as well as validated the `sfv` library as correctly handling duplicate parameters.
Description added. I also included a new patch to fix some typos in the core code.
Tests added! |
armfazh
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.