Skip to content

Introduce a pure-Rust implementation of HTTP message signatures and web_bot_auth #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2025
Merged

Introduce a pure-Rust implementation of HTTP message signatures and web_bot_auth #14

merged 4 commits into from
May 28, 2025

Conversation

AkshatM
Copy link
Contributor

@AkshatM AkshatM commented May 28, 2025 •
edited
Loading

For your review: @thibmeu

@AkshatM @gcloudflare @armfazh
Introduce a pure-Rust implementation of HTTP message signatures and
f150100 
web_bot_auth.

Co-authored-by: Gauri Baraskar <gbaraskar@cloudflare.com>
Co-authored-by: Armando Faz <armfazh@cloudflare.com>
@thibmeu thibmeu self-requested a review May 28, 2025 07:29
@thibmeu thibmeu added the enhancement New feature or request label May 28, 2025
@thibmeu
Copy link
Collaborator

thibmeu commented May 28, 2025

@AkshatM overall looks good. I have made some substantial modification as to how the code is organised AkshatM#1

@thibmeu
Organise rust code
6f613d2 
Add CI check
Make sure rust workspace is setup
Add rust exmamples in readme
fisherdarling
fisherdarling reviewed May 28, 2025
View reviewed changes
Copy link

@fisherdarling fisherdarling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some small comments.

I think we should eventually have an http feature which pulls in the http crate and adds the ability to easily sign and verify an http::Request. However, that might be a bit out of scope for the MVP.

thibmeu
thibmeu reviewed May 28, 2025
View reviewed changes
@thibmeu
Copy link
Collaborator

thibmeu commented May 28, 2025

I've suggested to release 0.0.1 instead of 0.1.0good to merge

thibmeu
thibmeu reviewed May 28, 2025
View reviewed changes
@AkshatM
Copy link
Contributor Author

AkshatM commented May 28, 2025

I've implemented all the missing docstrings, included Thibault's package reorganization, downgraded to 0.0.1, and otherwise implemented the rest of the suggestions.

@thibmeu thibmeu merged commit bde7742 into cloudflare:main May 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibmeu thibmeu thibmeu left review comments

@fisherdarling fisherdarling fisherdarling left review comments

Assignees

@AkshatM AkshatM

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkshatM @thibmeu @fisherdarling