Fix conflicts for PR 78 #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix empty string detection + undefined bypass * Delete upload file from R2 after cancel
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: yurhasko <yurij.hasko@gmail.com>
* Remove sha256 manifest from the tag list + Handle invalid n values + Dynamically add the next link if needed * Update tests to exclude SHA256 from tag listing * Change typo to camelCase
…re#92) * Add support for layer mounting cross repository * Refacto garbage collector selector: - Fix config blobs were delete when referenced - Add manifest-list support for multi-arch images - Add layer mounting support cross-repository * Upgrade tests with random blobs data + config blob different from layer blob * Add test for manifest list and garbage collector * Reduce number of tags for more vitest stability * Prevent recursive symlink * Fix typescript error for registry.list include option in garbage-collector.ts * Change typo to camelCase * Change typo to camelCase * Add mountExistingLayer to RegistryHTTPClient to satisfy Registry interface * Update symlinkHeader name * Update variable naming + add symlink filter optimisation
When there are many references in the R2 registry, the delete manifest endpoint responds with a 400 request and a cursor. The `list` call uses `startAfter` which is meant for filenames instead of the `cursor` which makes the `list` call return the same data on each call, despite of what's set in the `last` query parameter. This leads a caller following the `Link` call without checking whether the URL is the same as before to run into an infinite loop.
# Conflicts: # src/registry/garbage-collector.ts # src/registry/r2.ts # src/router.ts # test/index.test.ts
|
Hello @gabivlj any update on the subject ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the refacto of the garbage collector, there is some change needed to handle the new multi-part upload files. This PR handle conflict between the main branch and
gv/69branch.PS: The vitest error cmme from the direct import
import sha256Wasm from "@taylorzane/hash-wasm/wasm/sha256.wasm";inr2.tsline 37 but i'm not sure how to fix it properly.@gabivlj Any update to merge PR #78 ?