[ui-importer] add table name validation #4194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramprasadagarwal
requested review from
Copilot,
tabraiz12,
Harshg999 and
nidhibhatg
|
✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅ |
There was a problem hiding this comment.
Pull Request Overview
This PR adds table name validation to the UI importer component to prevent users from creating tables with names that already exist in the database. The validation displays an error alert when users enter a table name that conflicts with existing tables.
- Refactors the data catalog hook to use structured loading states and properly typed table metadata
- Creates a reusable FormInput component for consistent form field rendering across the application
- Implements real-time table name validation with visual error feedback in the destination settings
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| useDataCatalog.tsx | Updates hook to return structured table metadata and granular loading states |
| useDataCatalog.test.tsx | Updates tests to work with new structured loading states |
| FormInput.tsx | New reusable form input component supporting multiple field types |
| FormInput.test.tsx | Comprehensive tests for the new FormInput component |
| DestinationSettings.tsx | Integrates table validation and uses new FormInput component |
| DestinationSettings.test.tsx | Updates tests for new validation behavior and component structure |
| DestinationSettings.scss | Updates styles for new form layout structure |
desktop/core/src/desktop/js/utils/hooks/useDataCatalog/useDataCatalog.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/utils/hooks/useDataCatalog/useDataCatalog.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/utils/hooks/useDataCatalog/useDataCatalog.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/utils/hooks/useDataCatalog/useDataCatalog.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/utils/hooks/useDataCatalog/useDataCatalog.test.tsx
Outdated
Show resolved
Hide resolved
...top/js/apps/newimporter/ImporterFilePreview/DestinationSettings/DestinationSettings.test.tsx
Outdated
Show resolved
Hide resolved
...top/js/apps/newimporter/ImporterFilePreview/DestinationSettings/DestinationSettings.test.tsx
Outdated
Show resolved
Hide resolved
...top/js/apps/newimporter/ImporterFilePreview/DestinationSettings/DestinationSettings.test.tsx
Outdated
Show resolved
Hide resolved
...top/js/apps/newimporter/ImporterFilePreview/DestinationSettings/DestinationSettings.test.tsx
Outdated
Show resolved
Hide resolved
...top/js/apps/newimporter/ImporterFilePreview/DestinationSettings/DestinationSettings.test.tsx
Outdated
Show resolved
Hide resolved
UI Code Coverage Report
|
Backend Code Coverage Report •
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.