-
Notifications
You must be signed in to change notification settings - Fork 397
Fix IndexError in HiveServer2 Address Parsing via ZooKeeper in #4146 #4148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an IndexError in HiveServer2 address parsing by refining how ZooKeeper nodes are filtered and sorted based on sequence information. Key changes include initializing the hiveservers list instead of None, updating logging levels, and introducing a filtered and sorted list of nodes that contain a valid "sequence" pattern.
Comments suppressed due to low confidence (1)
apps/beeswax/src/beeswax/server/dbms.py:117
- When no sequence nodes are found, the function returns the original hiveservers list, which may include nodes that do not match the expected sequence pattern. This could result in an IndexError downstream; consider explicitly handling this scenario or filtering out nodes that could cause issues.
else:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
But there are test failures, Please review and address it.
apps/beeswax/src/beeswax/server/dbms.py:111:5: E265 [] Block comment should start with #
apps/beeswax/src/beeswax/server/dbms.py:118:48: W605 [] Invalid escape sequence: \d
Please help review the code @wing2fly @amitsrivastava @ranade1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Python Coverage Report •
Pytest Report
|
Hi @wing2fly @ramprasadagarwal @tabraiz12 @Harshg999 , the PR has passed all checks and reviews. Could you please approve the required workflows so it can be merged? Thanks! |
What changes were proposed in this pull request?
Fix IndexError in HiveServer2 Address Parsing via ZooKeeper in #4146
Please review Hue Contributing Guide before opening a pull request.