Skip to content

[ui-core] add useUrlListener hook #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ramprasadagarwal
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal commented May 2, 2025

What changes were proposed in this pull request?

  • When the user clicks on the left navigation icon on the React page, the URL is not updated due to a caching issue. and the user sees the correct UI with an incorrect URL.
    This hook listens to the URL change and re-renders the React page, and hence updates the correct URL.

How was this patch tested?

  • Will be adding tests once the implementation is approved.

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this May 2, 2025
Copy link

github-actions bot commented May 2, 2025

⚠️ No test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

github-actions bot commented May 2, 2025

Python Code Coverage

Python Coverage Report •
FileStmtsMissCoverMissing
TOTAL537132701149% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1090 106 💤 0 ❌ 0 🔥 5m 55s ⏱️

@ramprasadagarwal ramprasadagarwal marked this pull request as ready for review May 2, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant