[ui-importer] Adding column modal button to importer #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tabraiz12
reviewed
Apr 21, 2025
desktop/core/src/desktop/js/apps/newimporter/ImporterFilePreview/ColumnModal/ColumnModal.scss
Outdated
Show resolved
Hide resolved
ananya-agarwal
force-pushed
the
ColumnModal
branch
from
0ce1ac6 to
06fbda7
Compare
Python Coverage Report •
Pytest Report
|
ananya-agarwal
force-pushed
the
ColumnModal
branch
from
04dc9a1 to
46d622b
Compare
ramprasadagarwal
requested changes
Apr 21, 2025
desktop/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumn/EditColumn.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumn/EditColumn.tsx
Outdated
Show resolved
Hide resolved
bjornalm
reviewed
Apr 22, 2025
desktop/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumn/EditColumn.tsx
Outdated
Show resolved
Hide resolved
ananya-agarwal
force-pushed
the
ColumnModal
branch
4 times, most recently
from
17a43fb to
7db8537
Compare
Variable changing in scss file
Linting
nit nit again
…red code within importerFilePreview parent itself
ananya-agarwal
force-pushed
the
ColumnModal
branch
from
7db8537 to
153d977
Compare
ramprasadagarwal
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding edit columns button on the right and on clicking it, getting the empty modal with title and 2 buttons.
How was this patch tested?
Its about only adding a button and on clicking it, getting a modal.
Video of the update attached:
Screen.Recording.2025-04-21.at.7.38.07.PM.mov
Please review Hue Contributing Guide before opening a pull request.