Improvement - Hue Atlas search for classification and tags

[quadoss]

Based on a discussion with Atlas team, came to know that the query_s for searching classification or tags can be slow in Atlas and can lead to timeouts. Have made the needed changes based on Atlas team and this was tested in CU environment.

[github-actions]

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

[github-actions]

Backend Code Coverage Report •

File	Stmts	Miss	Cover	Missing
desktop/libs/metadata/src/metadata/catalog
atlas_client.py	305	255	16%	63, 65, 68, 70–73, 75–78, 80–82, 84–85, 87–91, 93, 95–96, 101, 103–111, 113, 116, 138–145, 147–152, 154, 183, 188–190, 193, 196–197, 199–200, 202–205, 207, 211–212, 214, 216, 220–221, 223, 225, 229–230, 233, 235, 239, 248–252, 254–255, 257, 259–261, 264–268, 270–273, 275–278, 280, 309–310, 316–317, 323–324, 327–330, 332–335, 337, 341–342, 344–349, 351–353, 358–360, 362–364, 371, 373–374, 376, 379–381, 383–386, 388, 391–395, 397, 404–409, 416, 418, 424–425, 427, 429–431, 433, 436, 446–449, 452–457, 460, 462–470, 473–478, 485–486, 488, 492–495, 497, 500–505, 507, 510–514, 516, 519–521, 523–525, 527, 530–534, 536, 539–541, 543–545, 547, 550–554, 556, 561–564, 566, 568–569, 581–582, 587, 590, 600, 603
TOTAL	53313	26124	51%

Pytest Report

Tests	Skipped	Failures	Errors	Time
1090	107 💤	0 ❌	0 🔥	5m 50s ⏱️

[amitsrivastava]

you are also switch the operator from contains to eq. Won't this have a significant change in the expected behavior?

[quadoss]

@amitsrivastava , The information was provided by Atlas team, I had no idea that there was an operator with eq there. Their recommendation was that Hue issuing contains with query_s causes performances issue and times out when there are too many things to look for and using __typename with eq and the attributevalue helps with getting the data out fast and also does not cause Atlas to perform massive query search operation.

[Harshg999]

Can we please add this info as a comment in the code?

[JohanAhlen]

I assume eq means exact match? IIRC this search also gets triggered from the top search where we'll need a "contains" search for usability.

[JohanAhlen]

I'm trying to say that we might need both, exact match when fetching details for a known sql entity and contains for user initiated search..

[Harshg999]

+1 for @JohanAhlen's statement and approach

[github-actions]

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

[github-actions]

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.