Skip to content

Change import order to fix app startup issues #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Change import order to fix app startup issues #245

merged 2 commits into from
Jun 12, 2025

Conversation

jkwatson
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reorders the import statements in the main application module and updates the patch logic for pysqlite3 to address startup issues, while also extending the release workflow to include an additional branch.

  • Reorders and annotates import statements in llm-service/app/main.py
  • Moves and deduplicates the pysqlite3 patch code
  • Adds the "customer-hotfix" branch to the release workflow trigger

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
llm-service/app/main.py Reorders imports and adjusts the pysqlite3 patch for improved startup
.github/workflows/publish_release.yml Adds "customer-hotfix" branch to the workflow branch list
Comments suppressed due to low confidence (1)

llm-service/app/main.py:51

  • Consider logging exception details using 'exc_info=True' or replacing 'logger.info' with 'logger.exception' to ensure the exception information is correctly captured.
logger.info(f"Unable to swap out pysqlite3. Probably not installed on your platform: {platform.system()}", e,)

logger = logging.getLogger(__name__)

try:
# Manual patch required for CrewAI compatability. DO NOT REMOVE. IT BREAKS ON OLD RUNTIMES IF YOU DO
Copy link
Preview

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the spelling of 'compatability' to 'compatibility' in the comment.

Suggested change
# Manual patch required for CrewAI compatability. DO NOT REMOVE. IT BREAKS ON OLD RUNTIMES IF YOU DO
# Manual patch required for CrewAI compatibility. DO NOT REMOVE. IT BREAKS ON OLD RUNTIMES IF YOU DO

Copilot uses AI. Check for mistakes.

@jkwatson jkwatson merged commit fbcb3f1 into release/1 Jun 12, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants