fix: satisfy newer Clippy lints to pass CI on latest Rust #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneychang
requested review from
bergwolf,
eryugey,
imeoer and
liubogithub
as code owners
sidneychang
force-pushed
the
fix_clippy_issue
branch
3 times, most recently
from
9aeb8da to
1ee418a
Compare
- replace Error::new(ErrorKind::Other, ...) with Error::other(...) - replace iter().map(|(_, v)| v.clone()) with values().map(|v| v.clone()) - add explicit `'_` lifetime in IoctlData return type - ensures compatibility with clippy --deny warnings on newer Rust
sidneychang
force-pushed
the
fix_clippy_issue
branch
from
1ee418a to
211ce26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'_lifetime in return type