This branch is just instructive of what needs to be removed to get to ~10m inserts per second #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
changed the title
cloutiertyler
force-pushed
the
tyler/bench-1m-base
branch
from
3a91708 to
2a98a03
Compare
cloutiertyler
commented
Jan 28, 2024
| @@ -168,49 +168,73 @@ impl BflatnSerializedRowBuffer<'_> { | |||
| let ty_alignment = ty.align(); | |||
| self.curr_offset = align_to(self.curr_offset, ty_alignment); | |||
|
|
|||
| match (ty, val) { | |||
There was a problem hiding this comment.
This change didn't really make much of a difference. It can probably be ignored. This function is definitely slow though and takes up quite a lot of time.
jdetter
added
the
Do not merge
jdetter
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.