Update GitHub files for C#/Unity SDK #2952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
commented
Jul 17, 2025
bfops
commented
Jul 17, 2025
bfops
commented
Jul 17, 2025
bfops
commented
Jul 17, 2025
bfops
commented
Jul 17, 2025
…csharp' into bfops/csharp-ci
bfops
changed the title
bfops
changed the title
jdetter
approved these changes
Jul 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update READMEs and CI related to the import of C#/Unity SDK stuff. Removed some CI that is now redundant. See inline comments for more details.
I also removed the
unity-tests~submodule that used to point to Blackholio, since that is now integrated into this repo as well (#2945).I also had to update the generated Blackholio bindings to make the CI pass, because they hadn't been updated in a while. However, in the previous repo, Blackholio was used as a submodule, so
git diffwas erroneously "passing" despite the fact that there was, in fact, a diff. Now that Blackholio is in the same repo,git diffin the CI is correctly detecting that the bindings need regenerating.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing