feat: add a opt-in validations of migrations #274
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cljoly
commented
May 19, 2025
| //! # Example | ||
| //! | ||
| //! ``` | ||
| //! #[cfg(test)] |
Owner
Author
There was a problem hiding this comment.
Remove this and the test annotation here and in the validate() example.
cljoly
commented
May 19, 2025
| self | ||
| } | ||
|
|
||
| /// Run the validations |
Owner
Author
There was a problem hiding this comment.
Place the example here instead of at the root of the module?
cljoly
commented
May 19, 2025
| /// | ||
| /// See the [`validations`] module if you want to validate other things as well, like downward | ||
| /// migrations. | ||
| /// |
Owner
Author
There was a problem hiding this comment.
Also change this to use the validation module, so the logic is not duplicated.
cljoly
commented
May 19, 2025
cljoly
force-pushed
the
cj/opt-in-val
branch
2 times, most recently
from
3464c7a to
e944978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may want to test downward migrations (#113). This is a
proposal for a composable set of checks (called validations), more or
less stringent, that users can run in a unit test.
More validations could be added in the future.
Closes #113