Skip to content

Fixups #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Fixups #1644

merged 3 commits into from
Apr 24, 2025

Conversation

bryteise
Copy link
Member

No description provided.

Signed-off-by: William Douglas <william.douglas@intel.com>
In order to get the content needed for check-update with the --verbose
option, root is required as data is put into the statedir. Keep the
old behavior when verbose isn't passed.

This was change was required because of the new latest file handling
for --incremental.

Signed-off-by: William Douglas <william.douglas@intel.com>
@bryteise bryteise force-pushed the fixups branch 3 times, most recently from aeffe42 to ab242a7 Compare April 24, 2025 19:40
The current format is very useful information to get from bug reports
so add it as default output to swupd update.

Signed-off-by: William Douglas <william.douglas@intel.com>
@bryteise bryteise requested a review from bwarden April 24, 2025 19:59
Copy link
Member

@bwarden bwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the updated test content, I found inconsistent escaping of parens in heredocs.

@bryteise
Copy link
Member Author

In the updated test content, I found inconsistent escaping of parens in heredocs.

The cases where the parens are escaped are because the test uses a regex vs the other cases where it is using the exact strings so no escape is needed.

@bryteise bryteise merged commit acad8c4 into master Apr 24, 2025
32 checks passed
@bryteise bryteise deleted the fixups branch April 24, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants