Skip to content

Allow user to specify encoding #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

einstein95
Copy link

This is my attempt at providing an updated version of #124. Comparing to that PR, I have:

  • added the encoding param to the documentation for the internal functions
  • defaulted the encoding param to an empty string so that using that variable within the function won't give any linter errors
  • added encoding type checking to get_file_from_iso in line with that section of the code
  • removed useless None default when using .get as the default is None
  • fix code in walk which ignored the default encoding when calling self.list_children

Test results as output by Github Actions:

====================== 1743 passed, 17 skipped in 10.99s =======================

@sev-
Copy link

sev- commented Jun 30, 2025

It would be really nice to have this merged. We are using your library in the ScummVM project (https://scummvm.org), and this is one of the problem we faced with: the Hybrid Mac/Windows CDs with Japanese filenames have the encoding lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants