Issue #3530263: Support message component updates in 642

[alan-cole]

https://www.drupal.org/project/civictheme/issues/3530263

Checklist before requesting a review

• I have formatted the subject to include ticket number as Issue #123456 by drupal_org_username: Issue title
• I have added a link to the issue tracker
• I have provided information in Changed section about WHY something was done if this was not a normal implementation
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• I have run new and existing relevant tests locally with my changes, and they passed
• I have provided screenshots, where applicable

Changed

1. Set the vertical_spacing on the message component for system messages. This is the integration ticket for the UI Kit update [#642] Updated message - Removed margin & added vertical_spacing prop. uikit#643.

Screenshots

Summary by CodeRabbit

• New Features
  • Improved status messages display by adding vertical spacing for better visual separation.

[coderabbitai]

Walkthrough

A new parameter named vertical_spacing with the value 'both' is added to the context when including the civictheme:message template in the status messages Twig file. No other logic or control flow is changed.

Changes

File(s)	Change Summary
.../civictheme/templates/misc/status-messages.html.twig	Added vertical_spacing: 'both' to the context for message template

Poem

A message gains new space to grow,
With "vertical_spacing" set just so.
Both above and below, it stands with pride,
In CivicTheme’s gentle, stylish stride.
Status now floats with room to spare—
A rabbit’s tweak for better air! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f39cb7 and 8d5532b.

📒 Files selected for processing (1)

• web/themes/contrib/civictheme/templates/misc/status-messages.html.twig (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (actions)
• GitHub Check: commit

🔇 Additional comments (1)

web/themes/contrib/civictheme/templates/misc/status-messages.html.twig (1)

9-14:

❌ Incorrect review comment

Scope vertical_spacing to status messages only.

As written, vertical_spacing: 'both' is passed to every message include. Confirm that the civictheme:message template accepts this param and that it’s intended for non-status messages as well. If the goal is to apply extra spacing only to system (status) messages, you can conditionally merge the property:

{% set context = {
  title: status_headings[type] ? status_headings[type] : type|capitalize,
  description: message,
  type: type == 'status' ? 'information' : type,
} %}
{% if type == 'status' %}
  {% set context = context|merge({ vertical_spacing: 'both' }) %}
{% endif %}
{% include 'civictheme:message' with context only %}

---

🏁 Script executed:

#!/bin/bash
set -e
echo "Finding message template files..."
find web/themes/contrib/civictheme/templates -type f -iname 'message*.html.twig'

echo
echo "Inspecting first 50 lines of each 'message' template:"
find web/themes/contrib/civictheme/templates -type f -iname 'message*.html.twig' -exec sh -c 'echo "=== {} ==="; head -n 50 {}' \;

echo
echo "Searching for any references to 'vertical_spacing' within the theme:"
rg 'vertical_spacing' -n web/themes/contrib/civictheme/templates || true

Length of output: 1865

---

Ignore spacing restriction – vertical_spacing is intentional across contexts.

The vertical_spacing parameter is passed to the civictheme:message include not only for system (status) messages but also in basic‐content and local‐tasks templates. Each of these relies on the vertical_spacing prop to control layout spacing. Restricting it to status messages would remove the intended spacing in those other contexts. No changes needed here.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.