Support DRF >=3.11.0 validator API changes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In encode/django-rest-framework#7062 the API for calling DRF validators changed to require the caller to inspect the validator instance to determine if the validator requires a second argument at call time. Usage with DRF >=3.11.0 requires this support.
|
I would be happy to submit this to the upstream repo as well (or instead), but I would really love to avoid forking and creating a drf-friendly-errors-3 at pypi. :) |
wmfgerrit
pushed a commit
to wikimedia/wikimedia-toolhub
that referenced
this pull request
Nov 17, 2020
Add a forked version of the drf-friendly-errors-2 library which created structured responses for API errors. These responses include error codes which should make error handling by API consumers slightly easier to implement. Using a forked library is hopefully a temporary solution. Our changes to implement support for current Django Rest Framework versions have been submitted upstream (<citixensas/drf-friendly-errors#2>). Bug: T267432 Change-Id: I483bf69de84c61f7dc589f547ee3ba0efbfc5529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In encode/django-rest-framework#7062 the API for calling DRF validators changed to require the caller to inspect the validator instance to determine if the validator requires a second argument at call time.