Add a lower-bound pin for pytest-testinfra
#201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
improvement
7 tasks
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
dv4harr10
approved these changes
Jun 25, 2024
dav3r
approved these changes
Jun 25, 2024
jsf9k
added
the
kraken 🐙
We do this because pytest-testinfra 10.1.1 contains a fix for SystemdService.exists that is required by some roles' Molecule test code. Note that we also add a corresponding line to the Dependabot configuration so that descendant repos know this dependency is managed here. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
jsf9k
force-pushed
the
improvement/add-prophylactic-pin
branch
from
b77120a to
bffee6b
Compare
cisagovbot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Apply our standard job preamble via cisagov/action-job-preamble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a lower-bound pin for
pytest-testinfra.💭 Motivation and context
We do this because
pytest-testinfra10.1.1 contains a fix forSystemdService.existsthat is required by some roles' Molecule test code.Note that we also add a corresponding line to the Dependabot configuration so that descendant repos know this dependency is managed here.
🧪 Testing
All automated tests pass. See also cisagov/ansible-role-systemd-resolved#8.
✅ Pre-approval checklist