Add a flag to allow adding restricted IP addresses #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
the
improvement
There are cases where restricted IPs may need to be added to the database. Therefore, we provide a flag to override the default behavior that disallows restricted IPs.
There are cases where restricted IPs may need to be added to the database. Therefore, we provide a flag to override the default behavior that disallows restricted IPs. Although the odds of needing this functionality in the cyhy-import tool are slim, we add it for feature consistency with the changes made to the cyhy-ip tool.
mcdonnnj
force-pushed
the
improvement/allow_restricted_ips_with_flag
branch
from
3de3e91 to
0456294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request implements a flag in both the
cyhy-ipandcyhy-toolscripts to allow restricted IPs to be added to the database.💭 Motivation and context
This closes #98.
🧪 Testing
W.I.P.
✅ Pre-approval checklist