Update json payload query support #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimac
commented
Oct 21, 2024
| assert.Equal(t, newExample.EncryptedIntField, example.EncryptedIntField, "EncryptedIntField does not match") | ||
| assert.Equal(t, newExample.EncryptedTextField, example.EncryptedTextField, "EncryptedTextField does not match") | ||
| assert.Equal(t, newExample.EncryptedJsonbField, example.EncryptedJsonbField, "EncryptedJsonbField does not match") | ||
| assert.Equal(t, newExample.NonEncryptedField, returnedExample.NonEncryptedField, "NonEncryptedField does not match") |
There was a problem hiding this comment.
Updated these assertions as the expected value should be the first value in the assertion.
func assert.Equal(t assert.TestingT, expected interface{}, actual interface{}, msgAndArgs ...interface{}) bool
fimac
commented
Oct 21, 2024
| EncryptedIntField: 23, | ||
| EncryptedTextField: "another string that shouldn't be returned", | ||
| EncryptedJsonbField: jsonData, | ||
| }, |
There was a problem hiding this comment.
Added another example to insert to ensure failures are picked up
https://cipherstash.slack.com/archives/C05CX3G2YQY/p1729475070543969
fimac
commented
Oct 21, 2024
| @@ -119,7 +125,7 @@ func TestMatchQueryLongString(t *testing.T) { | |||
| t.Errorf("Expected has to equal true, got: %v", has) | |||
| } | |||
|
|
|||
| assert.Equal(t, returnedExample.EncryptedTextField, EncryptedTextField("this is a long string"), "EncryptedTextField should match") | |||
| assert.Equal(t, EncryptedTextField("this is a long string"), returnedExample.EncryptedTextField, "EncryptedTextField should match") | |||
There was a problem hiding this comment.
same as above, expected should be first in the assertion
fimac
force-pushed
the
feat/update-json-payload-query-support
branch
from
c74b111 to
9366f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the payload to include a q value.
Adds query functions to use for each type to serialize the query into the required format.
Updates goeql tests.
Points eql sql install to central release folder that contains the latest sql for eql.