[ENH] Auto-set tenant in python CloudClient, add AdminCloudClient #5026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR updates the python CloudClient to auto-set tenant based on the API key, and deprecates unnecessary fields such as
tenant
,cloud_port
, andenable_ssl
. It also adds the AdminCloudClient, which introduces a new interface class, since cloud admin APIs are not 1:1 with the existing admin APIs. CloudAdminClient does not allow users to pass in tenants to functions, and will instead fetch the tenant using the provided api key at init time, and reuse that.to use the cloud client now
Test plan
How are these changes tested?
Manually tested both clients, and all corresponding APIs for both CloudClient (collection apis, add/delete records), and AdminClient (get_tenant & list/get_database, confirm create_tenant and create_database are disabled)
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?