Skip to content

[CHORE] Bump Compaction Sleep to 3 minutes. #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jul 1, 2025

Description of changes

We see during the course of test add that it will create up to 2.5
minutes backlog of collections and then flake the test. Better to make
it wait and always pass.

Test plan

CI

Documentation Changes

N/A

We see during the course of test add that it will create up to 2.5
minutes backlog of collections and then flake the test.  Better to make
it wait and always pass.
Copy link

github-actions bot commented Jul 1, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

This PR updates the compaction sleep interval in the test fixture configuration from 120 seconds (2 minutes) to 240 seconds (4 minutes) to address test flakiness caused by backlog buildup. The change is intended to ensure that tests have sufficient time to clear collection backlogs, as identified during CI runs.

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant