Remove MCP protocol tests #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove failing MCP protocol tests that were testing FastMCP's protocol handling rather than our application logic. These tests: - Failed with "Invalid request parameters" errors - Were excluded from CI pipeline - Provided no additional value over direct tool testing - Created maintenance burden and confusion Updated testing strategy documentation to explain our approach of testing tools directly rather than through the protocol layer.
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
* Start task: mcp-protocol-tests * Remove MCP protocol tests and update testing strategy Remove failing MCP protocol tests that were testing FastMCP's protocol handling rather than our application logic. These tests: - Failed with "Invalid request parameters" errors - Were excluded from CI pipeline - Provided no additional value over direct tool testing - Created maintenance burden and confusion Updated testing strategy documentation to explain our approach of testing tools directly rather than through the protocol layer. * Complete task: mcp-protocol-tests
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
* Start task: mcp-protocol-tests * Remove MCP protocol tests and update testing strategy Remove failing MCP protocol tests that were testing FastMCP's protocol handling rather than our application logic. These tests: - Failed with "Invalid request parameters" errors - Were excluded from CI pipeline - Provided no additional value over direct tool testing - Created maintenance burden and confusion Updated testing strategy documentation to explain our approach of testing tools directly rather than through the protocol layer. * Complete task: mcp-protocol-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The MCP protocol E2E tests were failing with "Invalid request parameters" (JSON-RPC error -32602) due to incompatibility between our custom MCPTestClient and FastMCP 1.12.2. These tests:
Solution
After investigation, I recommended and implemented removing these tests because:
Test plan