-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Container Name Conflicts Between Development and Production #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed default IMAGE_NAME in build script to troubleshoot-mcp-server-dev - Updated test harnesses to expect -dev container images - CI workflow override mechanism remains intact for production builds
- Updated PODMAN.md to use correct troubleshoot-mcp-server-dev:latest naming - Added container variants section to README.md explaining dev vs production images - Updated testing documentation with new container name - Corrected all example commands to use development image naming
Run black formatter on all Python files to ensure consistent code style
Use ruff format instead of black to match CI expectations
chris-sanders
added a commit
that referenced
this pull request
Jul 29, 2025
- fix-container-name-conflicts.md (PR #46 merged) - fix-asyncio-transport-python313.md (PR #42 merged) - fix-container-shutdown-race-condition.md (PR #41 merged) - fix-transport-cleanup-and-curl-dependency.md (PR #40 merged) - implement-comprehensive-testing-improvements.md (PR #39 merged) - switch-to-melange-apko-build.md (completed previously)
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
* Update container naming to use -dev suffix for development builds - Changed default IMAGE_NAME in build script to troubleshoot-mcp-server-dev - Updated test harnesses to expect -dev container images - CI workflow override mechanism remains intact for production builds * Update documentation for container variants - Updated PODMAN.md to use correct troubleshoot-mcp-server-dev:latest naming - Added container variants section to README.md explaining dev vs production images - Updated testing documentation with new container name - Corrected all example commands to use development image naming
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
- fix-container-name-conflicts.md (PR #46 merged) - fix-asyncio-transport-python313.md (PR #42 merged) - fix-container-shutdown-race-condition.md (PR #41 merged) - fix-transport-cleanup-and-curl-dependency.md (PR #40 merged) - implement-comprehensive-testing-improvements.md (PR #39 merged) - switch-to-melange-apko-build.md (completed previously)
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
* Update container naming to use -dev suffix for development builds - Changed default IMAGE_NAME in build script to troubleshoot-mcp-server-dev - Updated test harnesses to expect -dev container images - CI workflow override mechanism remains intact for production builds * Update documentation for container variants - Updated PODMAN.md to use correct troubleshoot-mcp-server-dev:latest naming - Added container variants section to README.md explaining dev vs production images - Updated testing documentation with new container name - Corrected all example commands to use development image naming
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
- fix-container-name-conflicts.md (PR #46 merged) - fix-asyncio-transport-python313.md (PR #42 merged) - fix-container-shutdown-race-condition.md (PR #41 merged) - fix-transport-cleanup-and-curl-dependency.md (PR #40 merged) - implement-comprehensive-testing-improvements.md (PR #39 merged) - switch-to-melange-apko-build.md (completed previously)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
troubleshoot-mcp-server:latest
totroubleshoot-mcp-server-dev:latest
for local developmenttroubleshoot-mcp-server:latest
imagesProblem Solved
Local development and testing previously used the same container image name (
troubleshoot-mcp-server:latest
) as official production releases, causing conflicts when users had the official container installed and wanted to run local development or testing on the same machine.Changes Made
Core Changes
scripts/build.sh
to default totroubleshoot-mcp-server-dev
image name-dev
suffix:tests/conftest.py
,tests/e2e/test_container_production_validation.py
,tests/e2e/test_container_bundle_validation.py
Documentation Updates
PODMAN.md
with correct container naming and explanation of variantsREADME.md
docs/TESTING_STRATEGY.md
with new image namesTesting
Acceptance Criteria Met
troubleshoot-mcp-server-dev:latest
troubleshoot-mcp-server:latest
IMAGE_NAME
override works-dev
suffix)Risk Mitigation
This change solves the core problem without over-engineering and maintains clear separation between development and production environments.