Audit and Fix Subprocess Dependencies - Replace ps/pkill with psutil #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ps/pkill subprocess calls at lines 1324, 1368, 2118, 2130 with psutil-based process management to eliminate external command dependencies. Changes: - Add psutil import to bundle.py - Replace ps -ef subprocess.run with psutil.process_iter() for process discovery - Replace pkill -f subprocess.run with psutil Process.terminate() for process termination - Add proper exception handling for psutil.NoSuchProcess, AccessDenied, ZombieProcess - Maintain same logic flow and error handling patterns - Add types-psutil dev dependency for mypy compatibility All existing tests pass and new ps/pkill dependency tests verify the fix works.
…ation - Create TDD functional test that exercises actual bundle cleanup behavior - Test catches ANY missing cleanup dependencies, not just ps/pkill - Simulates minimal container environment to verify external command elimination - Test validates cleanup works without external dependencies after psutil fix - Includes container-specific test marker for actual container validation
- Remove unused imports (patch, MagicMock, shutil) - Fix f-strings without placeholders - All ruff, black, and mypy checks now pass
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
…43) * Replace subprocess calls with psutil equivalents in bundle.py Replace ps/pkill subprocess calls at lines 1324, 1368, 2118, 2130 with psutil-based process management to eliminate external command dependencies. Changes: - Add psutil import to bundle.py - Replace ps -ef subprocess.run with psutil.process_iter() for process discovery - Replace pkill -f subprocess.run with psutil Process.terminate() for process termination - Add proper exception handling for psutil.NoSuchProcess, AccessDenied, ZombieProcess - Maintain same logic flow and error handling patterns - Add types-psutil dev dependency for mypy compatibility
chris-sanders
added a commit
that referenced
this pull request
Aug 11, 2025
…43) * Replace subprocess calls with psutil equivalents in bundle.py Replace ps/pkill subprocess calls at lines 1324, 1368, 2118, 2130 with psutil-based process management to eliminate external command dependencies. Changes: - Add psutil import to bundle.py - Replace ps -ef subprocess.run with psutil.process_iter() for process discovery - Replace pkill -f subprocess.run with psutil Process.terminate() for process termination - Add proper exception handling for psutil.NoSuchProcess, AccessDenied, ZombieProcess - Maintain same logic flow and error handling patterns - Add types-psutil dev dependency for mypy compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ps -efandpkill -fsubprocess calls with psutil equivalentsTest plan
Changes Made
ps -ef→psutil.process_iter()for finding processespkill -f "sbctl serve"→ psutil process terminationps -ef→psutil.process_iter()for process checkingpkill -f "sbctl"→ psutil process terminationThis eliminates the last major external command dependencies and makes the server more reliable in minimal container environments.