Fix type checking issues #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit installs the actual sbctl binary from github.com/replicatedhq/sbctl in the CI environment rather than relying on the mock implementation. This ensures integration tests can run properly on GitHub Actions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds appropriate exclusions to the ruff configuration in pyproject.toml to prevent linting of YAML files, which was causing CI failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixes f-string without placeholders in lifecycle.py - Adds .ruff.toml configurations to handle test fixtures properly - Creates directory-specific ruff configurations that relax rules for test code and fixtures which follow different patterns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Replaces a broken recursive symbolic link with a proper test file template. This fixes the "Failed to create cache key" error in CI linting. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Applied Black code formatter to all test files to ensure consistent formatting and pass CI checks. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This PR addresses type checking errors in the codebase that were preventing the CI checks from passing. Fixes include: 1. Add types-PyYAML to the dev dependencies for YAML type stubs 2. Initialize global variables in server.py properly 3. Fix missing return type annotations 4. Handle 'stream' attribute check more safely in CLI and main 5. Fix FastMCP stdio mode usage with environment variables 6. Create safe file copy helper function 7. Handle nullable types more safely in KubectlResult and KubectlError 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code