Skip to content

Conversation

chris-sanders
Copy link
Owner

Summary

  • Installs real sbctl binary from GitHub releases in the CI workflow
  • Removes reliance on mock_sbctl in CI environment
  • Ensures integration tests can run properly in GitHub Actions

Test plan

  • This PR should pass all integration tests in CI
  • Local test runs are unaffected

🤖 Generated with Claude Code

chris-sanders and others added 6 commits May 5, 2025 16:01
This commit installs the actual sbctl binary from github.com/replicatedhq/sbctl in the CI environment rather than relying on the mock implementation. This ensures integration tests can run properly on GitHub Actions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Adds appropriate exclusions to the ruff configuration in pyproject.toml
to prevent linting of YAML files, which was causing CI failures.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Fixes f-string without placeholders in lifecycle.py
- Adds .ruff.toml configurations to handle test fixtures properly
- Creates directory-specific ruff configurations that relax rules
  for test code and fixtures which follow different patterns

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Replaces a broken recursive symbolic link with a proper test file template.
This fixes the "Failed to create cache key" error in CI linting.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Applied Black code formatter to all test files to ensure consistent
formatting and pass CI checks.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@chris-sanders chris-sanders deleted the fix/install-sbctl-in-ci branch May 6, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant