Skip to content

Conversation

andrrizzi
Copy link
Contributor

These features were implemented originally in #365 and merged in #363, but we had to move them to a separate PR because we haven't resolved the performance issues that come with the CVCustomForce yet.

If the OpenMM performance does not increase, we may need to expose both versions: CVCustomForce and CustomCentroidBondForce.

@jchodera
Copy link
Member

I think we had decided to expose both CustomCVForce and non-CustomCVForce versions of these. Perhaps it would be simplest to retain the original force objects in openmmtools.forces and instead put the new CustomCVForce forces in openmmtools.cvforces, so we can simply import from one or the other to get the desired functionality?

@andrrizzi
Copy link
Contributor Author

I agree, but I'll keep this PR open until we solve the problem in any case as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants