(#3811) Centralize pinned-package message logic #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
centralize-pinned-message
branch
from
3648d9f to
3c6afe4
Compare
|
Internal builds and tests have succeeded. |
Refactor handling of pinned packages by extracting a single helper GetPinnedMessage and using it upgrade, outdated, and other flows. Adjust logging and result message order so that: - a consolidated message is built once and augmented depending on IgnorePinned setting. - Warn and Inconclusive ResultMessages are added consistently. - RegularOutput logging is preserved. - Control flow continues only when pinned packages are skipped. - Allows overridden services to provide their own pinned message. This reduces duplicated string formatting, clarifies when pinned packages are skipped vs upgraded.
Remove the redundant 'new' modifier from the Reset method in ChocolateyLicenseCommandSpecs.cs. The method does not hide any base member, so the 'new' keyword was unnecessary and could confuse readers or suggest unintended behavior. Simplifying the declaration improves code clarity and eliminates a potential compiler warning.
AdmiringWorm
force-pushed
the
centralize-pinned-message
branch
from
3c6afe4 to
4d632e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Refactor handling of pinned packages by extracting a single helper GetPinnedMessage and using it upgrade, outdated, and other flows. Adjust logging and result message order so that:
This reduces duplicated string formatting, clarifies when pinned packages are skipped vs upgraded.
Motivation and Context
To be able to override the pinned message in other products.
Testing
N/A - There are no differences in behavior, this is only needed for work being done elsewhere.
Will still run test kitchen against this PR.
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3811