Skip to content

Remove TCGPlayer deckbuilder integration #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

ndepaola
Copy link
Collaborator

Description

The deckbuilder was deactivated by TCGPlayer on 2025-05-14:
image

It's a shame to see this go - thanks @claythearc for originally contributing this in #68 :)

Checklist

  • I have installed pre-commit and installed the hooks with pre-commit install before creating any commits.
  • I have updated any related tests for code I modified or added new tests where appropriate.
  • I have manually tested my changes as follows:
    • Ensured TCGPlayer is no longer listed as a valid import site in the frontend
  • I have updated any relevant documentation or created new documentation where appropriate.
    • None required

@ndepaola
Copy link
Collaborator Author

Presumably TCGPlayer doesn't let you create new decks (or modify decks?) anymore, but the existing deck library is still accessible at time of writing. However, our integration is broken at the moment - after investigating a bit further, it seems like this code still works if User-Agent is set.

I'll go ahead with bandaiding the User-Agent for now and will close this PR (probably reopening it when the TCGPlayer deck builder is fully dead).

@ndepaola
Copy link
Collaborator Author

she dead jim

@ndepaola ndepaola moved this from Done to In Progress in MPC Autofill Backend May 29, 2025
as the deckbuilder was deactivated by tcgplayer on 2025-05-14
@ndepaola ndepaola force-pushed the remove-tcgplayer-decks-integration branch from 9293b08 to 40f12db Compare May 29, 2025 13:22
@ndepaola ndepaola merged commit 3ff732e into master May 29, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in MPC Autofill Backend May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant