Skip to content

Conversation

@avagin
Copy link
Member

@avagin avagin commented Nov 10, 2025

When we compare two list of vma-s, we need to take into account that some of them could be merged.

Fixes #2817

@avagin avagin requested a review from Copilot November 10, 2025 15:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the vdso-proxy test to handle the [vvar_vclock] virtual memory area and refactors the VMA comparison logic in the check_vvar_vdso function to properly handle overlapping and split memory regions.

  • Added recognition of [vvar_vclock] mappings as vvar/vdso regions
  • Rewrote the VMA comparison algorithm to handle VMA splits and partial overlaps more accurately
  • Fixed the loop increment logic to properly advance through both before/after VMA arrays

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avagin avagin requested a review from Copilot November 11, 2025 05:42
Copilot finished reviewing on behalf of avagin November 11, 2025 05:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

When we compare two list of vma-s, we need to take into account that
some of them could be merged.

Fixes #12286

Signed-off-by: Andrei Vagin <avagin@google.com>
@avagin avagin requested a review from Copilot November 11, 2025 06:11
Copilot finished reviewing on behalf of avagin November 11, 2025 06:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avagin avagin merged commit 8a076ef into checkpoint-restore:criu-dev Nov 11, 2025
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAIL: vdso-proxy.c:117: Lost vvar/vdso mapping #12286

1 participant