-
Notifications
You must be signed in to change notification settings - Fork 678
test/vdso-proxy: handle merged vma-s #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the vdso-proxy test to handle the [vvar_vclock] virtual memory area and refactors the VMA comparison logic in the check_vvar_vdso function to properly handle overlapping and split memory regions.
- Added recognition of
[vvar_vclock]mappings as vvar/vdso regions - Rewrote the VMA comparison algorithm to handle VMA splits and partial overlaps more accurately
- Fixed the loop increment logic to properly advance through both before/after VMA arrays
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0d8598d to
e70a912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When we compare two list of vma-s, we need to take into account that some of them could be merged. Fixes #12286 Signed-off-by: Andrei Vagin <avagin@google.com>
e70a912 to
4315172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When we compare two list of vma-s, we need to take into account that some of them could be merged.
Fixes #2817