pycriu: better dump errors
#2802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the reason for a dump fail (No dumps dir). Signed-off-by: Andrii Herheliuk <andrii@herheliuk.com>
avagin
reviewed
Oct 27, 2025
| s += "Bad options" | ||
|
|
||
| elif self.typ == rpc.DUMP and self.errno == errno.ENOENT: | ||
| s += "Dump folder not found. Please create it first." |
Member
There was a problem hiding this comment.
It can be a workdir and any other file patch. I think it is better to add cr_errmsg into the error message.
Member
Author
There was a problem hiding this comment.
I'm not sure how to find and send pr_perror's value back...
But it would make sense indeed. (Currently pycriu receives "Unknown" most of the time)
As far as this commit goes though, I believe the change in cr-service.c
and python check is enough to nail down this specific error.
Member
Author
There was a problem hiding this comment.
cr-sercice.c lines 137-142
static void set_resp_err(CriuResp *resp)
{
resp->cr_errno = get_cr_errno();
resp->has_cr_errno = resp->cr_errno ? true : false;
resp->cr_errmsg = log_first_err();
}
cr_errmsg is here, but pycriu doesn't seem to receive/process this value
Member
Author
There was a problem hiding this comment.
log_first_err() is returning NULL #2805
Edited: when using use_binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the reason for a dump fail (No dumps dir).
Signed-off-by: Andrii Herheliuk andrii@herheliuk.com