rpc.proto: making images_dir_fd optional
#2797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, using `images_dir` requires explicitly setting `opts.images_dir_fd` to `-1` for **every request**, because Protobuf treats the field as required, even though its default value is already `-1`. This makes the field unnecessarily mandatory. Signed-off-by: Andrii Herheliuk <andrii@herheliuk.com>
herheliuk
changed the title
images_dir_fd optional
Member
Author
|
current example of from pycriu import criu as pycriu_criu
criu = pycriu_criu()
criu.opts.images_dir_fd = -1
criu.opts.images_dir = dumps_dir
criu.opts.pid = int(input('pid: '))
criu.opts.shell_job = True
criu.dump()if we don't set google.protobuf.message.EncodeError: Message criu_req is missing required fields: opts.images_dir_fd |
rst0git
reviewed
Oct 23, 2025
|
|
||
| message criu_opts { | ||
| required int32 images_dir_fd = 1 [default = -1]; | ||
| optional int32 images_dir_fd = 1 [default = -1]; |
Member
There was a problem hiding this comment.
This change is likely to break existing users:
https://protobuf.dev/programming-guides/proto2/#required-deprecated
Member
Author
There was a problem hiding this comment.
we can hardcode req.opts.images_dir_fd = self.opts.images_dir_fd on every request, (in pycriu)
but it won't be that pretty.
I'm down for any solution, just to fix this inconvenience (and realistically barrier for newbies).
Member
Author
|
tests have failed. |
Member
Author
|
a different approach: #2798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using
images_dirrequires explicitly settingopts.images_dir_fdto-1for everyrequest, because Protobuf treats the field as required, even though its default value is already
-1.This makes the field unnecessarily mandatory.
Signed-off-by: Andrii Herheliuk andrii@herheliuk.com