Skip to content

Conversation

@herheliuk
Copy link
Member

pycriu depends on protobuf to function correctly. Currently,
it raises an error if protobuf is not installed. Adding
protobuf to the dependencies ensures it is available after
installing pycriu.

Signed-off-by: Andrii Herheliuk andrii@herheliuk.com

@herheliuk herheliuk changed the title lib/pyproject.toml: add missing protobuf dependency lib/pyproject.toml, setup.cfg: add missing protobuf dependency Oct 18, 2025
pycriu depends on protobuf to function correctly. Currently,
it raises an error if protobuf is not installed. Adding
protobuf to the dependencies ensures it is available after
installing pycriu.

Signed-off-by: Andrii Herheliuk <andrii@herheliuk.com>
@herheliuk herheliuk changed the title lib/pyproject.toml, setup.cfg: add missing protobuf dependency pycriu: add missing protobuf dependency Oct 18, 2025
@avagin
Copy link
Member

avagin commented Oct 19, 2025

LGTM. Thanks.

@rst0git rst0git merged commit ee1b495 into checkpoint-restore:criu-dev Oct 19, 2025
30 of 44 checks passed
@rst0git
Copy link
Member

rst0git commented Oct 20, 2025

This change causes some tests to fail:

Collecting protobuf (from pycriu==4.0)
  Downloading protobuf-6.33.0-cp39-abi3-manylinux2014_x86_64.whl.metadata (593 bytes)
Downloading protobuf-6.33.0-cp39-abi3-manylinux2014_x86_64.whl (323 kB)
Building wheels for collected packages: pycriu
  Building wheel for pycriu (pyproject.toml): started
  Building wheel for pycriu (pyproject.toml): finished with status 'done'
  Created wheel for pycriu: filename=pycriu-4.0-py3-none-any.whl size=93601 sha256=93e9c907cfeeadb4328e17cb31fcf48dbf2e280b59aceec397c1b69639c8f0fa
  Stored in directory: /tmp/pip-ephem-wheel-cache-vaf99pmu/wheels/10/d3/fb/8806d1d06158e3e4e86b5740f37869405f49aab92901d0d3eb
Successfully built pycriu
Installing collected packages: protobuf, pycriu

Successfully installed protobuf-6.33.0 pycriu-4.0
...

Files left after uninstall:
/criu/test/others/make/test.install-3023413/usr/local/lib64/python3.14/site-packages/protobuf-6.33.0.dist-info/WHEEL
/criu/test/others/make/test.install-3023413/usr/local/lib64/python3.14/site-packages/protobuf-6.33.0.dist-info/INSTALLER
/criu/test/others/make/test.install-3023413/usr/local/lib64/python3.14/site-packages/protobuf-6.33.0.dist-info/RECORD
make: *** [Makefile:4: run] Error 1

@herheliuk
Copy link
Member Author

herheliuk commented Oct 20, 2025

I can see that it's complaining that protobuf wasn't deleted after uninstall,
but it's not supposed to be deleted after uninstall, it's expected behaviour.

@herheliuk
Copy link
Member Author

herheliuk commented Oct 20, 2025

@rst0git I'll file a PR in a minute

@herheliuk
Copy link
Member Author

herheliuk commented Oct 20, 2025

#2790, Sorry didn't do it in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants